From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-renesas-soc@vger.kernel.org, joe@perches.com,
kernel-janitors@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-media@vger.kernel.org, linux-can@vger.kernel.org,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
Chien Tin Tung <chien.tin.tung@intel.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-scsi@
Subject: Re: [PATCH 00/26] constify local structures
Date: Mon, 12 Sep 2016 21:50:23 +0300 [thread overview]
Message-ID: <20160912185023.GB14727@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1609121548200.29099@hadrien>
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote:
>
>
> On Mon, 12 Sep 2016, Felipe Balbi wrote:
>
> >
> > Hi,
> >
> > Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> writes:
> > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> > >>
> > >>
> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> > >>
> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> > >> > > Constify local structures.
> > >> > >
> > >> > > The semantic patch that makes this change is as follows:
> > >> > > (http://coccinelle.lip6.fr/)
> > >> >
> > >> > Just my two cents but:
> > >> >
> > >> > 1. You *can* use a static analysis too to find bugs or other issues.
> > >> > 2. However, you should manually do the commits and proper commit
> > >> > messages to subsystems based on your findings. And I generally think
> > >> > that if one contributes code one should also at least smoke test changes
> > >> > somehow.
> > >> >
> > >> > I don't know if I'm alone with my opinion. I just think that one should
> > >> > also do the analysis part and not blindly create and submit patches.
> > >>
> > >> All of the patches are compile tested. And the individual patches are
> > >
> > > Compile-testing is not testing. If you are not able to test a commit,
> > > you should explain why.
> >
> > Dude, Julia has been doing semantic patching for years already and
> > nobody has raised any concerns so far. There's already an expectation
> > that Coccinelle *works* and Julia's sematic patches are sound.
> >
> > Besides, adding 'const' is something that causes virtually no functional
> > changes to the point that build-testing is really all you need. Any
> > problems caused by adding 'const' to a definition will be seen by build
> > errors or warnings.
> >
> > Really, just stop with the pointless discussion and go read a bit about
> > Coccinelle and what semantic patches are giving you. The work done by
> > Julia and her peers are INRIA have measurable benefits.
> >
> > You're really making a thunderstorm in a glass of water.
>
> Thanks for the defense, but since a lot of these patches torned out to be
> wrong, due to an incorrect parse by Coccinelle, combined with an
> unpleasantly lax compiler, Jarkko does have a point that I should have
> looked at the patches more carefully. In any case, I have written to the
> maintainers relevant to the patches that turned out to be incorrect.
Exactly. I'm not excepting that every commit would require extensive
analysis but it would be good to quickly at least skim through commits
and see if they make sense (or ask if unsure) :)
And I'm fine with compile testing if it is mentioned in the commit msg.
> julia
/Jarkko
next prev parent reply other threads:[~2016-09-12 18:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 13:05 [PATCH 00/26] constify local structures Julia Lawall
2016-09-11 13:05 ` [PATCH 05/26] ARCNET: " Julia Lawall
2016-09-12 12:31 ` Julia Lawall
2016-09-11 13:05 ` [PATCH 06/26] ath: " Julia Lawall
2016-09-14 17:02 ` [06/26] " Kalle Valo
2016-09-11 13:05 ` [PATCH 07/26] net/mlx4_core: " Julia Lawall
2016-09-12 4:59 ` Leon Romanovsky
2016-09-11 13:05 ` [PATCH 08/26] iwlegacy: " Julia Lawall
2016-09-12 11:24 ` Stanislaw Gruszka
2016-09-11 13:05 ` [PATCH 11/26] can: " Julia Lawall
2016-09-12 12:33 ` Julia Lawall
2016-09-11 13:06 ` [PATCH 20/26] stmmac: pci: " Julia Lawall
2016-09-12 12:08 ` Julia Lawall
[not found] ` <1473599168-30561-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2016-09-11 13:06 ` [PATCH 21/26] rtlwifi: rtl818x: " Julia Lawall
2016-09-11 17:21 ` [PATCH 00/26] " Jarkko Sakkinen
2016-09-12 8:54 ` Julia Lawall
2016-09-12 13:16 ` Jarkko Sakkinen
2016-09-12 13:23 ` Julia Lawall
2016-09-12 13:43 ` Felipe Balbi
2016-09-12 13:52 ` Julia Lawall
2016-09-12 18:50 ` Jarkko Sakkinen [this message]
2016-09-12 13:57 ` Geert Uytterhoeven
2016-09-12 20:14 ` Jarkko Sakkinen
2016-09-12 21:11 ` Julia Lawall
2016-09-11 17:56 ` Joe Perches
2016-09-11 19:11 ` Julia Lawall
2016-09-11 13:06 ` [PATCH 23/26] sh_eth: " Julia Lawall
2016-09-11 18:14 ` Sergei Shtylyov
2016-09-12 8:55 ` Julia Lawall
2016-09-12 9:43 ` Julia Lawall
2016-09-11 13:06 ` [PATCH 25/26] pch_gbe: " Julia Lawall
2016-09-12 2:48 ` David Miller
2016-09-12 9:07 ` Julia Lawall
2016-09-12 16:33 ` David Miller
2016-09-12 12:25 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912185023.GB14727@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=chien.tin.tung@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.balbi@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=shiraz.saleem@intel.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).