From: David Miller <davem@davemloft.net>
To: bhe@redhat.com
Cc: netdev@vger.kernel.org, sony.chacko@qlogic.com,
Dept-HSGLinuxNICDev@qlogic.com, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org
Subject: Re: [PATCH] bnx2: Reset device during driver initialization
Date: Tue, 13 Sep 2016 11:25:10 -0400 (EDT) [thread overview]
Message-ID: <20160913.112510.2054378133306191773.davem@davemloft.net> (raw)
In-Reply-To: <1473408667-7107-1-git-send-email-bhe@redhat.com>
From: Baoquan He <bhe@redhat.com>
Date: Fri, 9 Sep 2016 16:11:07 +0800
> When system enters into kdump kernel because of kernel panic, it won't
> shutdown devices. On-flight DMA will continue transferring data until
> device driver initializes. All devices are supposed to reset during
> driver initialization. And this property is used to fix the kdump
> failure in system with intel iommu. Other systems with hardware iommu
> should be similar. Please check commit 091d42e ("iommu/vt-d: Copy
> translation tables from old kernel") and those commits around it.
>
> But bnx2 driver doesn't reset device during driver initialization. The
> device resetting is deferred to net device up stage. This will cause
> hardware iommu handling failure on bnx2 device. And its resetting relies
> on firmware. So in this patch move the firmware requesting code to earlier
> bnx2_init_one(), then next call bnx2_reset_chip to reset device.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2016-09-13 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 8:11 [PATCH] bnx2: Reset device during driver initialization Baoquan He
2016-09-09 8:22 ` Baoquan He
2016-09-09 8:41 ` Joerg Roedel
2016-09-09 8:50 ` Baoquan He
2016-09-09 9:28 ` Baoquan He
2016-09-09 9:50 ` Baoquan He
2016-09-13 15:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913.112510.2054378133306191773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).