From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnx2: Reset device during driver initialization Date: Tue, 13 Sep 2016 11:25:10 -0400 (EDT) Message-ID: <20160913.112510.2054378133306191773.davem@davemloft.net> References: <1473408667-7107-1-git-send-email-bhe@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sony.chacko@qlogic.com, Dept-HSGLinuxNICDev@qlogic.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org To: bhe@redhat.com Return-path: In-Reply-To: <1473408667-7107-1-git-send-email-bhe@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Baoquan He Date: Fri, 9 Sep 2016 16:11:07 +0800 > When system enters into kdump kernel because of kernel panic, it won't > shutdown devices. On-flight DMA will continue transferring data until > device driver initializes. All devices are supposed to reset during > driver initialization. And this property is used to fix the kdump > failure in system with intel iommu. Other systems with hardware iommu > should be similar. Please check commit 091d42e ("iommu/vt-d: Copy > translation tables from old kernel") and those commits around it. > > But bnx2 driver doesn't reset device during driver initialization. The > device resetting is deferred to net device up stage. This will cause > hardware iommu handling failure on bnx2 device. And its resetting relies > on firmware. So in this patch move the firmware requesting code to earlier > bnx2_init_one(), then next call bnx2_reset_chip to reset device. > > Signed-off-by: Baoquan He Applied, thanks.