From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC 00/11] QLogic RDMA Driver (qedr) RFC Date: Tue, 13 Sep 2016 09:40:00 -0600 Message-ID: <20160913154000.GA25878@obsidianresearch.com> References: <1473696465-27986-1-git-send-email-Ram.Amrani@qlogic.com> <20160912180508.GI5843@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , David Miller , Yuval Mintz , Ariel Elior , Michal Kalderon , Rajesh Borundia , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , netdev To: Ram Amrani Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, Sep 13, 2016 at 08:44:06AM +0000, Ram Amrani wrote: > Hi Jason, > I see that "include/uapi/rdma" contains API that is common. It is intended to contain *all* the uapi. > The qedr_user.h, that I assume you are referring to, is a qedr specific API. > For example, we issue the ib_copy_to_udata() on structures defined in the file. > So per my understanding it is in place. Anything that is used with copy_to/from_user, ib_copy_to/from_udata, etc, etc must be in a include/uapi header. Any constant you might want to copy into your userspace provider must be in include/uapi. Avoid copying headers in your user space and use the standard kernel names to access your driver's uapi. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html