From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Dinan Gunawardena <dinan.gunawardena@netronome.com>,
Simon Horman <simon.horman@netronome.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH] nfp: fix error return code in nfp_net_netdev_open()
Date: Thu, 15 Sep 2016 08:43:22 +0100 [thread overview]
Message-ID: <20160915084322.56b84d90@jkicinski-Precision-T1700> (raw)
In-Reply-To: <1473911107-8427-1-git-send-email-weiyj.lk@gmail.com>
On Thu, 15 Sep 2016 03:45:07 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 73725d9dfd99 ("nfp: allocate ring SW structs dynamically")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
FWIW this is for net. Thanks Wei!
next prev parent reply other threads:[~2016-09-15 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 3:45 [PATCH] nfp: fix error return code in nfp_net_netdev_open() Wei Yongjun
2016-09-15 7:43 ` Jakub Kicinski [this message]
2016-09-16 8:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915084322.56b84d90@jkicinski-Precision-T1700 \
--to=jakub.kicinski@netronome.com \
--cc=dinan.gunawardena@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).