Netdev List
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	jiri@resnulli.us, john.fastabend@gmail.com, kubakici@wp.pl
Subject: Re: [PATCHv4 net-next 05/15] bpf: expose internal verfier structures
Date: Thu, 15 Sep 2016 13:09:46 -0700	[thread overview]
Message-ID: <20160915200944.GA74433@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <1473966755-30106-6-git-send-email-jakub.kicinski@netronome.com>

On Thu, Sep 15, 2016 at 08:12:25PM +0100, Jakub Kicinski wrote:
> Move verifier's internal structures to a header file and
> prefix their names with bpf_ to avoid potential namespace
> conflicts.  Those structures will soon be used by external
> analyzers.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> v4:
>  - separate from adding the analyzer;
>  - squash with the prefixing patch.
> ---
>  include/linux/bpf_verifier.h |  78 +++++++++++++
>  kernel/bpf/verifier.c        | 263 +++++++++++++++++--------------------------
>  2 files changed, 180 insertions(+), 161 deletions(-)
>  create mode 100644 include/linux/bpf_verifier.h
> 
> diff --git a/include/linux/bpf_verifier.h b/include/linux/bpf_verifier.h
> new file mode 100644
> index 000000000000..1c0511ef7eaf
> --- /dev/null
> +++ b/include/linux/bpf_verifier.h
...
> +#ifndef _LINUX_BPF_ANALYZER_H
> +#define _LINUX_BPF_ANALYZER_H 1

the macro doesn't match the file name.
Other than that
Acked-by: Alexei Starovoitov <ast@kernel.org>

  reply	other threads:[~2016-09-15 20:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 19:12 [PATCHv4 net-next 00/15] BPF hardware offload (cls_bpf for now) Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 01/15] net: cls_bpf: add hardware offload Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 02/15] net: cls_bpf: limit hardware offload by software-only flag Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 03/15] net: cls_bpf: add support for marking filters as hardware-only Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 04/15] bpf: don't (ab)use instructions to store state Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 05/15] bpf: expose internal verfier structures Jakub Kicinski
2016-09-15 20:09   ` Alexei Starovoitov [this message]
2016-09-15 19:12 ` [PATCHv4 net-next 06/15] bpf: enable non-core use of the verfier Jakub Kicinski
2016-09-15 20:10   ` Alexei Starovoitov
2016-09-15 19:12 ` [PATCHv4 net-next 07/15] bpf: recognize 64bit immediate loads as consts Jakub Kicinski
2016-09-15 20:12   ` Alexei Starovoitov
2016-09-15 19:12 ` [PATCHv4 net-next 08/15] nfp: add BPF to NFP code translator Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 09/15] nfp: bpf: add hardware bpf offload Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 10/15] net: cls_bpf: allow offloaded filters to update stats Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 11/15] nfp: bpf: " Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 12/15] nfp: bpf: add packet marking support Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 13/15] net: act_mirred: allow statistic updates from offloaded actions Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 14/15] nfp: bpf: add support for legacy redirect action Jakub Kicinski
2016-09-15 19:12 ` [PATCHv4 net-next 15/15] nfp: bpf: add offload of TC direct action mode Jakub Kicinski
2016-09-15 20:16 ` [PATCHv4 net-next 00/15] BPF hardware offload (cls_bpf for now) Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915200944.GA74433@ast-mbp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@resnulli.us \
    --cc=john.fastabend@gmail.com \
    --cc=kubakici@wp.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox