From: Ido Schimmel <idosch@idosch.org>
To: John Crispin <john@phrozen.org>
Cc: Elad Raz <eladr@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ido Schimmel <idosch@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: MDB offloading of local ipv4 multicast groups
Date: Thu, 15 Sep 2016 23:42:18 +0300 [thread overview]
Message-ID: <20160915204218.GA21035@splinter> (raw)
In-Reply-To: <ebb1092f-4fab-c490-0553-b108feb5e8d4@phrozen.org>
On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote:
> Hi,
>
> While adding MDB support to the qca8k dsa driver I found that ipv4 mcast
> groups don't always get propagated to the dsa driver. In my setup there
> are 2 clients connected to the switch, both running a mdns client. The
> .port_mdb_add() callback is properly called for 33:33:00:00:00:FB but
> 01:00:5E:00:00:FB never got propagated to the dsa driver.
>
> The reason is that the call to ipv4_is_local_multicast() here [1] will
> return true and the notifier is never called. Is this intentional or is
> there something missing in the code ?
I believe this is based on RFC 4541:
"Packets with a destination IP (DIP) address in the 224.0.0.X range
which are not IGMP must be forwarded on all ports."
https://tools.ietf.org/html/rfc4541
But, we are missing the offloading of router ports, which is needed for
the device to correctly flood unregistered multicast packets. That's
also according to the mentioned RFC:
"If a switch receives an unregistered packet, it must forward that
packet on all ports to which an IGMP router is attached."
Implemented at br_flood_multicast()
However, the marking is done per-port and not per-{port, VID}. We need
that in case vlan filtering is enabled. I think Nik is working on that,
but he can correct me if I'm wrong :). The switchdev bits can be added
soon after.
>
> John
>
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/net/bridge/br_multicast.c?id=refs/tags/v4.8-rc6#n737
next prev parent reply other threads:[~2016-09-15 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 18:58 MDB offloading of local ipv4 multicast groups John Crispin
2016-09-15 20:42 ` Ido Schimmel [this message]
2016-09-16 6:22 ` John Crispin
2016-09-15 22:28 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915204218.GA21035@splinter \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=john@phrozen.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).