From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 0/7] add enhancement into the existing reset flow Date: Fri, 16 Sep 2016 02:23:25 -0400 (EDT) Message-ID: <20160916.022325.1284944952505020198.davem@davemloft.net> References: <1473866001-9805-1-git-send-email-sean.wang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, keyhaede-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, objelf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Return-path: In-Reply-To: <1473866001-9805-1-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Date: Wed, 14 Sep 2016 23:13:14 +0800 > From: Sean Wang > > Current driver only resets DMA used by descriptor rings which > can't guarantee it can recover all various kinds of fatal > errors, so the patch > 1) tries to reset the underlying hardware resource from scratch on > Mediatek SoC required for ethernet running. > 2) refactors code in order to the reusability of existing code. > 3) considers handling for race condition between the reset flow and > callbacks registered into core driver called about hardware accessing. > 4) introduces power domain usage to hardware setup which leads to have > cleanly and completely restore to the state as the initial. > > Changes since v1: > - fix the build error with module built causing undefined symbol for > pinctrl_bind_pins, so using pinctrl_select_state instead accomplishes > the pin mux setup during the reset process. Series applied, thanks.