From: David Miller <davem@davemloft.net>
To: mark.tomlinson@alliedtelesis.co.nz
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: VRF: Pass original iif to ip_route_input()
Date: Fri, 16 Sep 2016 04:24:48 -0400 (EDT) [thread overview]
Message-ID: <20160916.042448.465580563570138252.davem@davemloft.net> (raw)
In-Reply-To: <20160914234005.1240-1-mark.tomlinson@alliedtelesis.co.nz>
From: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Date: Thu, 15 Sep 2016 11:40:05 +1200
> The function ip_rcv_finish() calls l3mdev_ip_rcv(). On any VRF except
> the global VRF, this replaces skb->dev with the VRF master interface.
> When calling ip_route_input_noref() from here, the checks for forwarding
> look at this master device instead of the initial ingress interface.
> This will allow packets to be routed which normally would be dropped.
> For example, an interface that is not assigned an IP address should
> drop packets, but because the checking is against the master device, the
> packet will be forwarded.
>
> The fix here is to still call l3mdev_ip_rcv(), but remember the initial
> net_device. This is passed to the other functions within ip_rcv_finish,
> so they still see the original interface.
>
> Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> Acked-by: David Ahern <dsa@cumulusnetworks.com>
Applied.
prev parent reply other threads:[~2016-09-16 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 1:45 [PATCH] net: VRF: Pass original iif to ip_route_input() Mark Tomlinson
2016-09-12 14:48 ` David Ahern
2016-09-14 19:29 ` David Ahern
2016-09-14 23:40 ` [PATCH v2] " Mark Tomlinson
2016-09-16 8:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916.042448.465580563570138252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=mark.tomlinson@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).