* [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning
@ 2016-09-15 2:24 Wei Yongjun
2016-09-15 2:46 ` Florian Fainelli
2016-09-16 8:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-09-15 2:24 UTC (permalink / raw)
To: David S . Miller, Florian Fainelli, Vivien Didelot, Andrew Lunn,
Jiri Pirko
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/dsa/bcm_sf2.c:963:19: warning:
symbol 'bcm_sf2_io_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/dsa/bcm_sf2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index 51f1fc0..f8bb5a5 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -960,7 +960,7 @@ static int bcm_sf2_core_write64(struct b53_device *dev, u8 page, u8 reg,
return 0;
}
-struct b53_io_ops bcm_sf2_io_ops = {
+static struct b53_io_ops bcm_sf2_io_ops = {
.read8 = bcm_sf2_core_read8,
.read16 = bcm_sf2_core_read16,
.read32 = bcm_sf2_core_read32,
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning
2016-09-15 2:24 [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning Wei Yongjun
@ 2016-09-15 2:46 ` Florian Fainelli
2016-09-16 8:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2016-09-15 2:46 UTC (permalink / raw)
To: Wei Yongjun
Cc: David S . Miller, Vivien Didelot, Andrew Lunn, Jiri Pirko,
Wei Yongjun, netdev
2016-09-14 19:24 GMT-07:00 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/dsa/bcm_sf2.c:963:19: warning:
> symbol 'bcm_sf2_io_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning
2016-09-15 2:24 [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning Wei Yongjun
2016-09-15 2:46 ` Florian Fainelli
@ 2016-09-16 8:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-09-16 8:26 UTC (permalink / raw)
To: weiyj.lk; +Cc: f.fainelli, vivien.didelot, andrew, jiri, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Thu, 15 Sep 2016 02:24:13 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/dsa/bcm_sf2.c:963:19: warning:
> symbol 'bcm_sf2_io_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 2:24 [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning Wei Yongjun
2016-09-15 2:46 ` Florian Fainelli
2016-09-16 8:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).