From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, tom@herbertland.com,
bblanco@plumgrid.com, rana.shahot@gmail.com, brouer@redhat.com
Subject: Re: [net PATCH V3] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full
Date: Mon, 19 Sep 2016 09:42:19 +0200 [thread overview]
Message-ID: <20160919094219.5b0d11cd@redhat.com> (raw)
In-Reply-To: <20160919.013925.1660395475687226712.davem@davemloft.net>
On Mon, 19 Sep 2016 01:39:25 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Jesper Dangaard Brouer <brouer@redhat.com>
> Date: Sat, 17 Sep 2016 17:48:00 +0200
>
> > The XDP_TX action can fail transmitting the frame in case the TX ring
> > is full or port is down. In case of TX failure it should drop the
> > frame, and not as now call 'break' which is the same as XDP_PASS.
> >
> > Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support")
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
> Oops, I applied v2 of this patch. Please send me any necessary
> relative fixups, thanks.
Okay, I just send the needed fix up in/with:
Subj: [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-09-19 7:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 20:36 [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full Jesper Dangaard Brouer
2016-09-16 20:37 ` Jesper Dangaard Brouer
2016-09-16 20:43 ` Brenden Blanco
2016-09-17 14:46 ` Jesper Dangaard Brouer
2016-09-17 15:48 ` [net PATCH V3] " Jesper Dangaard Brouer
2016-09-18 8:30 ` Tariq Toukan
2016-09-19 5:39 ` David Miller
2016-09-19 7:40 ` [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure Jesper Dangaard Brouer
2016-09-19 10:54 ` Tariq Toukan
2016-09-19 14:28 ` Eric Dumazet
2016-09-19 15:46 ` [net-next PATCH V2] " Jesper Dangaard Brouer
2016-09-20 8:58 ` David Miller
2016-09-19 15:57 ` [net-next PATCH] " Jesper Dangaard Brouer
2016-09-19 7:42 ` Jesper Dangaard Brouer [this message]
2016-09-19 5:32 ` [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919094219.5b0d11cd@redhat.com \
--to=brouer@redhat.com \
--cc=bblanco@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rana.shahot@gmail.com \
--cc=tariqt@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).