From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Pravin Shelar <pshelar@ovn.org>
Subject: Re: [PATCH v2 1/2] net: skbuff: Remove errornous length validation in skb_vlan_pop()
Date: Mon, 19 Sep 2016 19:28:56 +0300 [thread overview]
Message-ID: <20160919192856.31bacaba@halley> (raw)
In-Reply-To: <1474300400-32362-1-git-send-email-shmulik.ladkani@gmail.com>
On Mon, 19 Sep 2016 18:53:19 +0300 Shmulik Ladkani <shmulik.ladkani@gmail.com> wrote:
> Remove the 'skb->len < VLAN_ETH_HLEN' condition entirely:
> It is superfluous since inner '__skb_vlan_pop' already verifies there
> are VLAN_ETH_HLEN writable bytes at the mac_header.
Please disregard, will send a v3.
prev parent reply other threads:[~2016-09-19 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 15:53 [PATCH v2 1/2] net: skbuff: Remove errornous length validation in skb_vlan_pop() Shmulik Ladkani
2016-09-19 15:53 ` [PATCH v2 2/2] net: skbuff: Coding: Use eth_type_vlan() instead of open coding it Shmulik Ladkani
2016-09-19 16:20 ` Eric Dumazet
2016-09-19 16:23 ` Shmulik Ladkani
2016-09-19 17:37 ` Eric Dumazet
2016-09-19 16:28 ` Shmulik Ladkani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919192856.31bacaba@halley \
--to=shmulik.ladkani@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).