From: David Miller <davem@davemloft.net>
To: vincent@bernat.im
Cc: dsa@cumulusnetworks.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [v3] net: ipv6: fallback to full lookup if table lookup is unsuitable
Date: Tue, 20 Sep 2016 03:29:10 -0400 (EDT) [thread overview]
Message-ID: <20160920.032910.512829220195292472.davem@davemloft.net> (raw)
In-Reply-To: <20160918154607.5474-1-vincent@bernat.im>
From: Vincent Bernat <vincent@bernat.im>
Date: Sun, 18 Sep 2016 17:46:07 +0200
> Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop
> lookups") introduced a regression: insertion of an IPv6 route in a table
> not containing the appropriate connected route for the gateway but which
> contained a non-connected route (like a default gateway) fails while it
> was previously working:
>
> $ ip link add eth0 type dummy
> $ ip link set up dev eth0
> $ ip addr add 2001:db8::1/64 dev eth0
> $ ip route add ::/0 via 2001:db8::5 dev eth0 table 20
> $ ip route add 2001:db8:cafe::1/128 via 2001:db8::6 dev eth0 table 20
> RTNETLINK answers: No route to host
> $ ip -6 route show table 20
> default via 2001:db8::5 dev eth0 metric 1024 pref medium
>
> After this patch, we get:
>
> $ ip route add 2001:db8:cafe::1/128 via 2001:db8::6 dev eth0 table 20
> $ ip -6 route show table 20
> 2001:db8:cafe::1 via 2001:db8::6 dev eth0 metric 1024 pref medium
> default via 2001:db8::5 dev eth0 metric 1024 pref medium
>
> Fixes: 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups")
> Signed-off-by: Vincent Bernat <vincent@bernat.im>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2016-09-20 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 12:55 [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable Vincent Bernat
2016-09-16 18:36 ` David Ahern
2016-09-16 19:15 ` Vincent Bernat
2016-09-16 19:38 ` David Ahern
2016-09-16 20:33 ` [v2] " Vincent Bernat
2016-09-18 15:12 ` David Ahern
2016-09-18 15:46 ` [v3] " Vincent Bernat
2016-09-18 15:47 ` David Ahern
2016-09-20 7:29 ` David Miller [this message]
2016-09-19 4:58 ` [PATCH] " David Miller
2016-09-19 20:27 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920.032910.512829220195292472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=vincent@bernat.im \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).