* [PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB
@ 2016-09-20 7:36 Michael Chan
2016-09-20 7:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2016-09-20 7:36 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Rob Swindell <swindell@broadcom.com>
bnxt_hwrm_fw_set_time() now returns -EOPNOTSUPP when built for kernel
without RTC_LIB. Setting the firmware time is not critical to the
successful completion of the firmware update process.
Signed-off-by: Rob Swindell <Rob.Swindell@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index cbc0b8a..a9f9f37 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4323,6 +4323,7 @@ hwrm_ver_get_exit:
int bnxt_hwrm_fw_set_time(struct bnxt *bp)
{
+#if IS_ENABLED(CONFIG_RTC_LIB)
struct hwrm_fw_set_time_input req = {0};
struct rtc_time tm;
struct timeval tv;
@@ -4340,6 +4341,9 @@ int bnxt_hwrm_fw_set_time(struct bnxt *bp)
req.minute = tm.tm_min;
req.second = tm.tm_sec;
return hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
+#else
+ return -EOPNOTSUPP;
+#endif
}
static int bnxt_hwrm_port_qstats(struct bnxt *bp)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB
2016-09-20 7:36 [PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB Michael Chan
@ 2016-09-20 7:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-09-20 7:54 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Tue, 20 Sep 2016 03:36:33 -0400
> From: Rob Swindell <swindell@broadcom.com>
>
> bnxt_hwrm_fw_set_time() now returns -EOPNOTSUPP when built for kernel
> without RTC_LIB. Setting the firmware time is not critical to the
> successful completion of the firmware update process.
>
> Signed-off-by: Rob Swindell <Rob.Swindell@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-20 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-20 7:36 [PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB Michael Chan
2016-09-20 7:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).