From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tgraf-G/eBtMaohhA@public.gmane.org,
tom-BjP2VixgY4xUbtYUoyoikg@public.gmane.org,
greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org
Subject: Re: [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects
Date: Tue, 20 Sep 2016 04:44:19 -0400 (EDT) [thread overview]
Message-ID: <20160920.044419.79616518616678600.davem@davemloft.net> (raw)
In-Reply-To: <1474284732.6544.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Date: Mon, 19 Sep 2016 13:32:12 +0200
> On Mon, 2016-09-19 at 13:03 +0200, Johannes Berg wrote:
>> On Mon, 2016-09-19 at 18:58 +0800, Herbert Xu wrote:
>> >
>> > v3 fixes a bug in the remove path that causes the element count
>> > to decrease when it shouldn't, leading to a gigantic hash table
>> > when it underflows.
>> >
>> Ok, with the BUG_ON() thrown in, this works in the test that was
>> failing before. I'll run the entire suite again over lunch.
>>
>
> Ok, the entire test suite passed (with the BUG_ON, but hey).
>
> Dave, let me know what you want to do (or have done, as it may be).
I'll apply this directly to net-next and push it out after some
build testing.
Thanks guys.
prev parent reply other threads:[~2016-09-20 8:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:18 Buggy rhashtable walking Herbert Xu
[not found] ` <20160804071846.GA773-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2016-08-04 7:45 ` Herbert Xu
2016-08-05 6:16 ` Johannes Berg
[not found] ` <1470377813.2977.14.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-08-05 10:48 ` Herbert Xu
2016-08-05 10:50 ` Johannes Berg
2016-08-05 11:46 ` Ben Greear
[not found] ` <57A47CA3.4010101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2016-08-08 15:26 ` Herbert Xu
[not found] ` <1470394233.2977.37.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-18 13:50 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Herbert Xu
2016-09-18 13:53 ` [PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-18 13:54 ` [PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 8:20 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 8:25 ` Johannes Berg
[not found] ` <1474273518.4469.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 8:35 ` Herbert Xu
2016-09-19 8:58 ` Johannes Berg
2016-09-19 8:40 ` [v2 PATCH " Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 9:15 ` [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
[not found] ` <1474276530.4469.16.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 9:17 ` Herbert Xu
2016-09-19 9:27 ` Johannes Berg
2016-09-19 9:31 ` Johannes Berg
[not found] ` <1474277244.4469.21.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 9:34 ` Herbert Xu
[not found] ` <20160919093434.GA12378-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2016-09-19 9:38 ` Johannes Berg
2016-09-19 9:50 ` Johannes Berg
[not found] ` <1474278634.4469.25.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 9:54 ` Johannes Berg
[not found] ` <1474278896.4469.26.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 10:02 ` Johannes Berg
[not found] ` <1474279330.4469.28.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 10:04 ` Johannes Berg
[not found] ` <1474279492.4469.29.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 10:10 ` Johannes Berg
2016-09-19 10:48 ` Herbert Xu
[not found] ` <20160919104801.GA12774-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2016-09-19 10:58 ` Johannes Berg
[not found] ` <20160919084056.GA11875-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2016-09-19 10:58 ` [v3 " Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 21:16 ` Thomas Graf
2016-09-20 1:52 ` Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 11:03 ` [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
[not found] ` <1474283023.6544.0.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-19 11:32 ` Johannes Berg
[not found] ` <1474284732.6544.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-09-20 8:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920.044419.79616518616678600.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tgraf-G/eBtMaohhA@public.gmane.org \
--cc=tom-BjP2VixgY4xUbtYUoyoikg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).