From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: netdev@vger.kernel.org, David.Laight@ACULAB.com,
Yuval.Mintz@caviumnetworks.com
Subject: Re: [PATCH net v2] qed: Fix stack corruption on probe
Date: Tue, 20 Sep 2016 04:57:50 -0400 (EDT) [thread overview]
Message-ID: <20160920.045750.166537005858505924.davem@davemloft.net> (raw)
In-Reply-To: <1474296461-22558-1-git-send-email-Yuval.Mintz@qlogic.com>
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Mon, 19 Sep 2016 17:47:41 +0300
> Commit fe56b9e6a8d95 ("qed: Add module with basic common support")
> has introduced a stack corruption during probe, where filling a
> local struct with data to be sent to management firmware is incorrectly
> filled; The data is written outside of the struct and corrupts
> the stack.
>
> Changes from v1:
> ----------------
> - Correct the value written [Caught by David Laight]
>
> Fixes: fe56b9e6a8d95 ("qed: Add module with basic common support")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
Applied, thanks.
prev parent reply other threads:[~2016-09-20 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 14:47 [PATCH net v2] qed: Fix stack corruption on probe Yuval Mintz
2016-09-19 16:37 ` David Laight
2016-09-19 17:24 ` Mintz, Yuval
2016-09-20 8:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920.045750.166537005858505924.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.com \
--cc=Yuval.Mintz@caviumnetworks.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).