From: Stephen Hemminger <stephen@networkplumber.org>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: netdev@vger.kernel.org,
Konstantin Khorenko <khorenko@virtuozzo.com>,
crml <criu@openvz.org>
Subject: Re: [PATCH 3/6] ip xfrm state: add save/restore
Date: Tue, 20 Sep 2016 09:43:31 -0700 [thread overview]
Message-ID: <20160920094331.4a3c08de@xeon-e3> (raw)
In-Reply-To: <1472806946-16575-4-git-send-email-ptikhomirov@virtuozzo.com>
On Fri, 2 Sep 2016 12:02:23 +0300
Pavel Tikhomirov <ptikhomirov@virtuozzo.com> wrote:
> +static __u32 state_dump_magic = 0x71706987;
> +
> +static int xfrm_state_list_deleteall_or_save(int argc, char **argv, int deleteall, int save)
I have no problem with the overall functionality of this patch set, but this
function_name_is_too_long_for_rational_humans.
Please make the function names (especially the local static ones) shorter and more reasonable
and resubmit
next prev parent reply other threads:[~2016-09-20 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 9:02 [PATCH 0/6] ip: add save/restore to xfrm tables Pavel Tikhomirov
2016-09-02 9:02 ` [PATCH 1/6] ip: merge together all save_xxx_preps and xxx_dump_check_magics Pavel Tikhomirov
2016-09-02 9:02 ` [PATCH 2/6] ip: merge together all save_xxx to save_nlmsg Pavel Tikhomirov
2016-09-02 9:02 ` [PATCH 3/6] ip xfrm state: add save/restore Pavel Tikhomirov
2016-09-20 16:43 ` Stephen Hemminger [this message]
2016-09-02 9:02 ` [PATCH 4/6] ip xfrm policy: " Pavel Tikhomirov
2016-09-02 9:02 ` [PATCH 5/6] ip xfrm state: fixup hard/soft timeouts/limits while save Pavel Tikhomirov
2016-09-02 9:02 ` [PATCH 6/6] ip xfrm policy: " Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920094331.4a3c08de@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=criu@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).