From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, "Mintz,
Yuval" <Yuval.Mintz@cavium.com>
Subject: Re: [PATCH net-next v2 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.
Date: Tue, 20 Sep 2016 15:52:14 +0100 [thread overview]
Message-ID: <20160920155214.3ea1e280@jkicinski-Precision-T1700> (raw)
In-Reply-To: <1474354228-3221-6-git-send-email-michael.chan@broadcom.com>
Hi!
On Tue, 20 Sep 2016 02:50:23 -0400, Michael Chan wrote:
> The existing code is inconsistent in reporting and accepting the combined
> channel count. bnxt_get_channels() reports maximum combined as the
> maximum rx count. bnxt_set_channels() accepts combined count that
> cannot be bigger than max rx or max tx.
>
> For example, if max rx = 2 and max tx = 1, we report max supported
> combined to be 2. But if the user tries to set combined to 2, it will
> fail because 2 is bigger than max tx which is 1.
>
> Fix the code to be consistent. Max allowed combined = max(max_rx, max_tx).
> We will accept a combined channel count <= max(max_rx, max_tx).
>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Sorry I wasn't able to respond in time but I'm with Yuval on this one.
The canonical meaning for the parameters is set by man page for ethtool:
> rx N Changes the number of channels with only receive queues.
>
> tx N Changes the number of channels with only transmit queues.
>
> other N
> Changes the number of channels used only for other purposes e.g.
> link interrupts or SR-IOV co-ordination.
>
> combined N
> Changes the number of multi-purpose channels.
Could we please agree that combined means having both RX and TX and the
others mean having only the specified one? See for example:
e261768e9e39 ("be2net: support asymmetric rx/tx queue counts")
next prev parent reply other threads:[~2016-09-20 14:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 6:50 [PATCH net-next v2 00/10] bnxt: update for net-next Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 01/10] bnxt_en: Use RSS flags defined in the bnxt_hsi.h file Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 02/10] bnxt_en: Simplify PCI device names and add additinal PCI IDs Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 03/10] bnxt_en: Update to firmware interface spec 1.5.1 Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 04/10] bnxt_en: Added support for Secure Firmware Update Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts Michael Chan
2016-09-20 14:52 ` Jakub Kicinski [this message]
2016-09-20 6:50 ` [PATCH net-next v2 06/10] bnxt_en: Re-arrange bnxt_hwrm_func_qcaps() Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 07/10] bnxt_en: Call firmware to approve the random VF MAC address Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 08/10] bnxt_en: Pad TX packets below 52 bytes Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 09/10] bnxt_en: Support for "ethtool -r" command Michael Chan
2016-09-20 6:50 ` [PATCH net-next v2 10/10] bnxt_en: Fixed the VF link status after a link state change Michael Chan
2016-09-20 7:26 ` [PATCH net-next v2 00/10] bnxt: update for net-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920155214.3ea1e280@jkicinski-Precision-T1700 \
--to=jakub.kicinski@netronome.com \
--cc=Yuval.Mintz@cavium.com \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).