From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Elior, Ariel" <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: "Amrani,
Ram" <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Kalderon,
Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Mintz,
Yuval" <Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Borundia,
Rajesh" <Rajesh.Borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC
Date: Tue, 20 Sep 2016 19:23:06 +0300 [thread overview]
Message-ID: <20160920162306.GP26673@leon.nu> (raw)
In-Reply-To: <CY1PR0701MB133773B2CB71FA6362CADCFF90F70-UpKza+2NMNLi6bjPjkn3FE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]
On Tue, Sep 20, 2016 at 01:33:25PM +0000, Elior, Ariel wrote:
> > On Tue, Sep 20, 2016 at 01:35:52PM +0300, Ram Amrani wrote:
> ...
> > > The series adds on top of RFC v1:
> > > * a check for all drivers that IB_ACCESS_MW_BIND isn't set for ib_get_dma_mr
> > > * relocation of qedr user API to include/rdma/uapi/providers/
> > > * removal of qedr_devlist_local
> > > * fixed error handling in qedr_alloc_resources()
> > > * configuration of PBL in ib_map_mr_sg() driver implementation,
> > > rather than post_send's IB_WR_REG_MR
> > > * misc.: placed code in proper patch, fixed a few comments,
> > > removed extra parentheses
> > >
> > > Thanks for everyone which pointed out problems in the driver.
> > >
> > > Any review/comment is appreciated.
> >
> > Very nice,
> > Any reason why didn't you drop debug module parameter and decided to
> > mimic already available kernel core functionality?
> >
> > You got technical explanations why it is bad idea to use it. If you need additional
> > voices
> > to support my claims, you will find them in thread about VERBOSE flag and responses
> > from
> > Doug, and Dennis.
> >
> > Thanks
> Hi Leon,
> The RFC cover letter lists what has been addressed. Debug printouts are not addressed in V2 as the discussion on that topic is not concluded (more thoughts from us on debug printouts incoming on the thread). There were many comments to V1 which are not relevant to debug printouts which are addressed by V2. We are requesting further comment, hence RFC V2. Rest assured, if it is the final opinion in the relevant discussion that pr_debug is the way to go, that's what we'll do.
The module parameters is no-go.
> Thanks,
> Ariel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-20 16:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 10:35 [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Ram Amrani
2016-09-20 10:35 ` [RFC v2 01/12] qed: Add LL2 Ram Amrani
2016-09-20 10:35 ` [RFC v2 03/12] qedr: Add support for RoCE HW init Ram Amrani
2016-09-20 10:35 ` [RFC v2 06/12] qedr: Add support for QP verbs Ram Amrani
[not found] ` <1474367764-9555-7-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 15:28 ` Jason Gunthorpe
[not found] ` <20160920152849.GD32020-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 14:23 ` Amrani, Ram
[not found] ` <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-21 15:55 ` Jason Gunthorpe
[not found] ` <20160921155509.GC1510-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-22 6:51 ` Amrani, Ram
2016-09-20 16:30 ` Leon Romanovsky
2016-09-21 14:15 ` Amrani, Ram
2016-09-22 13:32 ` Leon Romanovsky
2016-09-20 10:36 ` [RFC v2 08/12] qedr: Add support for data path Ram Amrani
[not found] ` <1474367764-9555-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 10:35 ` [RFC v2 02/12] qedr: Add RoCE driver framework Ram Amrani
2016-09-20 10:35 ` [RFC v2 04/12] qedr: Add support for user context verbs Ram Amrani
2016-09-20 15:27 ` Jason Gunthorpe
2016-09-21 14:20 ` Amrani, Ram
[not found] ` <1474367764-9555-5-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 16:45 ` Leon Romanovsky
[not found] ` <20160920164556.GS26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:18 ` Amrani, Ram
2016-09-20 10:35 ` [RFC v2 05/12] qedr: Add support for PD,PKEY and CQ verbs Ram Amrani
2016-09-20 10:35 ` [RFC v2 07/12] qedr: Add support for memory registeration verbs Ram Amrani
2016-09-21 19:53 ` Sagi Grimberg
2016-09-20 10:36 ` [RFC v2 09/12] qedr: Add LL2 RoCE interface Ram Amrani
2016-09-20 10:36 ` [RFC v2 10/12] qedr: Add GSI support Ram Amrani
2016-09-20 12:11 ` [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Leon Romanovsky
[not found] ` <20160920121151.GK26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 13:33 ` Elior, Ariel
[not found] ` <CY1PR0701MB133773B2CB71FA6362CADCFF90F70-UpKza+2NMNLi6bjPjkn3FE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-20 16:23 ` Leon Romanovsky [this message]
[not found] ` <20160920162306.GP26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:19 ` Amrani, Ram
2016-09-20 10:36 ` [RFC v2 11/12] qedr: Add events support and register IB device Ram Amrani
2016-09-20 10:36 ` [RFC v2 12/12] IB/core: add a protection to ib_get_dma_mr Ram Amrani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920162306.GP26673@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Rajesh.Borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).