From: Jiri Benc <jbenc@redhat.com>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
hannes@stressinduktion.org, aduyck@mirantis.com,
daniel@iogearbox.net, pabeni@redhat.com
Subject: Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()
Date: Tue, 20 Sep 2016 19:09:29 +0200 [thread overview]
Message-ID: <20160920190929.57ddaeb0@griffin> (raw)
In-Reply-To: <20160920184333.17444823@griffin>
On Tue, 20 Sep 2016 18:43:33 +0200, Jiri Benc wrote:
> On Tue, 20 Sep 2016 12:31:08 -0400, Sowmini Varadhan wrote:
> > The vxlan header is after the ethernet header (14 bytes),
> > IP header (20 bytes, assuming no options) and udp header (8 bytes).
>
> If the VXLAN header is not aligned to 4 bytes, then IP header is not
> aligned to 4 bytes, too, and you have greater problems than just VXLAN.
...which is indeed the case. Sorry, I guess I'm too much focused on
VXLAN-GPE nowadays and I missed that we're building this before the
inner Ethernet header.
But the point stands, we have much greater problems here than VXLAN.
And I don't think that wrapping all IP address accesses into
get/put_unaligned all around the stack is the solution.
Jiri
next prev parent reply other threads:[~2016-09-20 17:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 14:27 [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb() Sowmini Varadhan
2016-09-20 15:31 ` Tom Herbert
2016-09-20 15:49 ` Sowmini Varadhan
2016-09-20 16:11 ` Jiri Benc
2016-09-20 16:31 ` Sowmini Varadhan
2016-09-20 16:43 ` Jiri Benc
2016-09-20 17:07 ` Sowmini Varadhan
2016-09-20 17:15 ` Jiri Benc
2016-09-20 17:09 ` Jiri Benc [this message]
2016-09-20 17:19 ` Tom Herbert
2016-09-20 17:24 ` Sowmini Varadhan
2016-09-22 5:52 ` David Miller
2016-09-22 21:30 ` Sowmini Varadhan
2016-09-23 12:06 ` David Miller
2016-09-23 14:17 ` Alexander Duyck
2016-09-23 17:20 ` Sowmini Varadhan
2016-09-23 17:38 ` Alexander Duyck
2016-09-23 23:41 ` Sowmini Varadhan
2016-09-24 0:43 ` Alexander Duyck
2016-09-28 17:03 ` Sowmini Varadhan
2016-09-28 18:08 ` Alexander Duyck
2016-09-28 19:56 ` Sowmini Varadhan
2016-09-20 16:45 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920190929.57ddaeb0@griffin \
--to=jbenc@redhat.com \
--cc=aduyck@mirantis.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).