From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Tariq Toukan <tariqt@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Rana Shahout <ranas@mellanox.com>,
brouer@redhat.com
Subject: Re: [PATCH net-next 7/8] net/mlx5e: XDP TX forwarding support
Date: Wed, 21 Sep 2016 10:16:49 +0200 [thread overview]
Message-ID: <20160921101649.44894f5b@redhat.com> (raw)
In-Reply-To: <84150f05-7eb3-d35c-32fd-4b9853f6f114@gmail.com>
On Wed, 21 Sep 2016 10:57:34 +0300
Tariq Toukan <ttoukan.linux@gmail.com> wrote:
> On 20/09/2016 6:40 PM, Alexei Starovoitov wrote:
> > On Tue, Sep 20, 2016 at 03:53:10PM +0300, Tariq Toukan wrote:
> >>>>> + case XDP_ABORTED:
> >>>> It is not clearly defined, but I believe XDP_ABORTED should also result
> >>>> in a warning (calling bpf_warn_invalid_xdp_action(act)).
> >> I'll add this.
> > Certainly NOT.
> > XDP_ABORTED is an exception case when program does divide by zero.
> > It should NOT do bpf_warn. It must drop the packet.
> > We discussed it several months ago.
> > See mlx4/en_rx.c for canonical implementation.
> >
> This is also the example given here:
> https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/implementation/xdp_actions.html#code-example
>
Nice, the documentation is already useful :-)))
I actually adjusted the code example after this feedback. Which I also
wrote in this email thread about updating the documentation. I already
pointed to this commit, but here is a more specific link:
https://github.com/netoptimizer/prototype-kernel/commit/3925249089ae4#diff-c9b8ab4ded3eed2e92f8d898111d8e9bL74
> I prefer to align with the documentation (and with current mlx4 driver
> code), which means keeping the XDP_ABORTED w/o a warning.
> Anyway, I don't think this should block the coming V2. If you decide to
> change documentation/specification, we will simply adjust our drivers
> accordingly.
This is not blocking your V2, please resend so we can all start working
on a common code base for mlx5 (I'm currently running mlx5 with my own
one-page-per-packet patch... and my page_pool on-top)
As discussed in this thread, the outcome will likely be a new interface
for Troubleshooting and Monitoring, as documented and summarized here
so we don't forget:
https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/implementation/userspace_api.html#troubleshooting-and-monitoring
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-09-21 8:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 13:58 [PATCH net-next 0/8] mlx5e XDP support Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 1/8] net/mlx5e: Build RX SKB on demand Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 2/8] net/mlx5e: Union RQ RX info per RQ type Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 3/8] net/mlx5e: Slightly reduce hardware LRO size Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 4/8] net/mlx5e: Dynamic RQ type infrastructure Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 5/8] net/mlx5e: XDP fast RX drop bpf programs support Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 6/8] net/mlx5e: Have a clear separation between different SQ types Tariq Toukan
2016-09-19 13:58 ` [PATCH net-next 7/8] net/mlx5e: XDP TX forwarding support Tariq Toukan
2016-09-20 8:29 ` Jesper Dangaard Brouer
2016-09-20 11:33 ` Jesper Dangaard Brouer
2016-09-20 12:53 ` Tariq Toukan
2016-09-20 15:40 ` Alexei Starovoitov
2016-09-20 15:51 ` Tom Herbert
2016-09-20 15:58 ` Eric Dumazet
2016-09-20 16:06 ` Jesper Dangaard Brouer
2016-09-20 16:13 ` Eric Dumazet
2016-09-20 16:27 ` Jesper Dangaard Brouer
2016-09-20 16:45 ` Alexei Starovoitov
2016-09-20 16:58 ` Thomas Graf
2016-09-20 17:39 ` Eric Dumazet
2016-09-20 18:59 ` Jesper Dangaard Brouer
2016-09-20 19:21 ` Tom Herbert
2016-09-20 20:47 ` Jesper Dangaard Brouer
2016-09-20 21:04 ` Jesper Dangaard Brouer
2016-09-20 16:00 ` Alexei Starovoitov
2016-09-20 15:57 ` Jesper Dangaard Brouer
2016-09-21 7:57 ` Tariq Toukan
2016-09-21 8:16 ` Jesper Dangaard Brouer [this message]
2016-09-19 13:58 ` [PATCH net-next 8/8] net/mlx5e: XDP TX xmit more Tariq Toukan
2016-09-20 7:46 ` Jesper Dangaard Brouer
2016-09-20 8:19 ` Tariq Toukan
2016-09-20 9:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921101649.44894f5b@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ranas@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).