From: Jiri Benc <jbenc@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Richard Cochran <richardcochran@gmail.com>,
John Stultz <john.stultz@linaro.org>,
Josh Triplett <josh@joshtriplett.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] make POSIX timers optional
Date: Wed, 21 Sep 2016 12:20:30 +0200 [thread overview]
Message-ID: <20160921122030.408c97f1@griffin> (raw)
In-Reply-To: <alpine.DEB.2.20.1609202300140.5476@nanos>
On Tue, 20 Sep 2016 23:09:52 +0200 (CEST), Thomas Gleixner wrote:
> Now if you want to distangle PTP from a driver then you split it at the
> driver level and not at the PTP level:
>
> DRIVER_X
> tristate "Driver X"
>
> DRIVER_X_PTP
> bool "Enable PTP support"
> default y if !MAKE_IT_TINY
> depends on DRIVER_X
> select PTP
Ouch. So, after the hassle to remove the VXLAN and GENEVE configs from
tons of drivers, we'll add another one instead? That's just silly. If
we did this for every thing we support in NICs, we would end up with
something completely unmanageable.
PTP should be really configured by a single switch.
Btw., your suggestion does not work, select is not recursive.
> We have already drivers following that scheme. That way you make the PTP
> support in the driver conditional on DRIVER_X_PTP and have no hassle with
> modules and dependencies.
We've recently got rid of some of those, thankfully. Caused more harm
than good.
Jiri
next prev parent reply other threads:[~2016-09-21 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 19:56 [PATCH v2 0/2] make POSIX timers optional Nicolas Pitre
2016-09-20 19:56 ` [PATCH 1/2] ptp_clock: allow for it to be optional Nicolas Pitre
2016-09-20 19:56 ` [PATCH 2/2] posix-timers: make it configurable Nicolas Pitre
2016-09-20 20:25 ` [PATCH v2 0/2] make POSIX timers optional Richard Cochran
2016-09-20 20:45 ` Richard Cochran
2016-09-20 20:58 ` Nicolas Pitre
2016-09-20 21:09 ` Thomas Gleixner
2016-09-20 22:47 ` Nicolas Pitre
2016-09-21 8:38 ` Richard Cochran
2016-09-21 10:27 ` Jiri Benc
2016-09-21 9:09 ` Thomas Gleixner
2016-09-21 10:20 ` Jiri Benc [this message]
2016-09-20 20:52 ` Nicolas Pitre
2016-09-22 6:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921122030.408c97f1@griffin \
--to=jbenc@redhat.com \
--cc=john.stultz@linaro.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).