From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Amrani, Ram" <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: "davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Elior,
Ariel" <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Kalderon,
Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Mintz,
Yuval" <Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"Borundia,
Rajesh" <Rajesh.Borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC v2 06/12] qedr: Add support for QP verbs
Date: Wed, 21 Sep 2016 09:55:09 -0600 [thread overview]
Message-ID: <20160921155509.GC1510@obsidianresearch.com> (raw)
In-Reply-To: <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Wed, Sep 21, 2016 at 02:23:46PM +0000, Amrani, Ram wrote:
> > Ugh, each patch keeps adding to this?
>
> The logic in the patch series is to have each patch contain only
> what is necessary for the specific functionality it adds. This made
> it harder on us to prepare but, IMHO, easier for the reviewer. If
> you'd like to have this file in one chunk, I can do this. What do
> you prefer?
I wouldn't change anything at this point, but I'm not sure it is
easier to review like this than the one patch per file scheme.
Do you have a git tree?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-21 15:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 10:35 [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Ram Amrani
2016-09-20 10:35 ` [RFC v2 01/12] qed: Add LL2 Ram Amrani
2016-09-20 10:35 ` [RFC v2 03/12] qedr: Add support for RoCE HW init Ram Amrani
2016-09-20 10:35 ` [RFC v2 06/12] qedr: Add support for QP verbs Ram Amrani
[not found] ` <1474367764-9555-7-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 15:28 ` Jason Gunthorpe
[not found] ` <20160920152849.GD32020-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-21 14:23 ` Amrani, Ram
[not found] ` <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-09-21 15:55 ` Jason Gunthorpe [this message]
[not found] ` <20160921155509.GC1510-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-22 6:51 ` Amrani, Ram
2016-09-20 16:30 ` Leon Romanovsky
2016-09-21 14:15 ` Amrani, Ram
2016-09-22 13:32 ` Leon Romanovsky
2016-09-20 10:36 ` [RFC v2 08/12] qedr: Add support for data path Ram Amrani
[not found] ` <1474367764-9555-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 10:35 ` [RFC v2 02/12] qedr: Add RoCE driver framework Ram Amrani
2016-09-20 10:35 ` [RFC v2 04/12] qedr: Add support for user context verbs Ram Amrani
2016-09-20 15:27 ` Jason Gunthorpe
2016-09-21 14:20 ` Amrani, Ram
[not found] ` <1474367764-9555-5-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-09-20 16:45 ` Leon Romanovsky
[not found] ` <20160920164556.GS26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:18 ` Amrani, Ram
2016-09-20 10:35 ` [RFC v2 05/12] qedr: Add support for PD,PKEY and CQ verbs Ram Amrani
2016-09-20 10:35 ` [RFC v2 07/12] qedr: Add support for memory registeration verbs Ram Amrani
2016-09-21 19:53 ` Sagi Grimberg
2016-09-20 10:36 ` [RFC v2 09/12] qedr: Add LL2 RoCE interface Ram Amrani
2016-09-20 10:36 ` [RFC v2 10/12] qedr: Add GSI support Ram Amrani
2016-09-20 12:11 ` [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC Leon Romanovsky
[not found] ` <20160920121151.GK26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-20 13:33 ` Elior, Ariel
[not found] ` <CY1PR0701MB133773B2CB71FA6362CADCFF90F70-UpKza+2NMNLi6bjPjkn3FE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-20 16:23 ` Leon Romanovsky
[not found] ` <20160920162306.GP26673-2ukJVAZIZ/Y@public.gmane.org>
2016-09-21 14:19 ` Amrani, Ram
2016-09-20 10:36 ` [RFC v2 11/12] qedr: Add events support and register IB device Ram Amrani
2016-09-20 10:36 ` [RFC v2 12/12] IB/core: add a protection to ib_get_dma_mr Ram Amrani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921155509.GC1510@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Rajesh.Borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).