From: Stephen Hemminger <stephen@networkplumber.org>
To: Neal Cardwell <ncardwell@google.com>
Cc: netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <edumazet@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH iproute2 3/3] ss: output TCP BBR diag information
Date: Wed, 21 Sep 2016 16:31:20 -0700 [thread overview]
Message-ID: <20160921163120.03c126d3@xeon-e3> (raw)
In-Reply-To: <1474425824-22646-3-git-send-email-ncardwell@google.com>
On Tue, 20 Sep 2016 22:43:44 -0400
Neal Cardwell <ncardwell@google.com> wrote:
> Dump useful TCP BBR state information from a struct tcp_bbr_info that
> was grabbed using the inet_diag API.
>
> We tolerate info that is shorter or longer than expected, in case the
> kernel is older or newer than the ss binary. We simply print the
> minimum of what is expected from the kernel and what is provided from
> the kernel. We use the same trick as that used for struct tcp_info:
> when the info from the kernel is shorter than we hoped, we pad the end
> with zeroes, and don't print fields if they are zero.
>
> The BBR output looks like:
> bbr:(bw:1.2Mbps,mrtt:18.965,pacing_gain:2.88672,cwnd_gain:2.88672)
>
> The motivation here is to be consistent with DCTCP, which looks like:
> dctcp(ce_state:23,alpha:23,ab_ecn:23,ab_tot:23)
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Applied, to net-next.
The first two patches were unnecessary. Already picked up current net-next headers.
prev parent reply other threads:[~2016-09-21 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 2:43 [PATCH iproute2 1/3] Update inet_diag.h header to pick up INET_DIAG_MARK Neal Cardwell
2016-09-21 2:43 ` [PATCH iproute2 2/3] Update inet_diag.h to include INET_DIAG_BBRINFO and related structs Neal Cardwell
2016-09-21 2:43 ` [PATCH iproute2 3/3] ss: output TCP BBR diag information Neal Cardwell
2016-09-21 23:31 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921163120.03c126d3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox