From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipvlan: fix building without netfilter Date: Thu, 22 Sep 2016 08:32:05 -0400 (EDT) Message-ID: <20160922.083205.2034005377472668654.davem@davemloft.net> References: <20160922094130.2154824-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: maheshb@google.com, dsa@cumulusnetworks.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20160922094130.2154824-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Thu, 22 Sep 2016 11:40:52 +0200 > The new l3s mode in ipvlan relies on netfilter interfaces, but > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, > leading to a build error: > > drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct nf_hook_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > drivers/net/ipvlan/ipvlan_main.c:14:27: error: array type has incomplete element type 'struct nf_hook_ops' > ... > > This adds a forward declaration for struct nf_hook_state, and hides > the newly added l3s code in an #ifdef. > > Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode") > Signed-off-by: Arnd Bergmann I'm pretty sure I applied a Kconfig patch that added the necessary dependency.