netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 2/2] ip rule: add selector support
Date: Thu, 22 Sep 2016 10:45:53 +0200	[thread overview]
Message-ID: <20160922084553.GA22100@orbyte.nwl.cc> (raw)
In-Reply-To: <1474525729-2845-3-git-send-email-liuhangbin@gmail.com>

On Thu, Sep 22, 2016 at 02:28:49PM +0800, Hangbin Liu wrote:
[...]
> diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8
> index 3508d80..ec0e31d 100644
> --- a/man/man8/ip-rule.8
> +++ b/man/man8/ip-rule.8
> @@ -15,7 +15,8 @@ ip-rule \- routing policy database management
>  
>  .ti -8
>  .B  ip rule
> -.RB "[ " list " ]"
> +.RB "[ " list
> +.I "[ " SELECTOR " ]]"

This makes the brackets cursive, too. Better use this instead:

| .RI "[ " SELECTOR " ]]"

Apart from that, LGTM!

Thanks, Phil

  reply	other threads:[~2016-09-22  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22  6:28 [PATCH iproute2 0/2] ip rule: merger iprule_flush and add selector support Hangbin Liu
2016-09-22  6:28 ` [PATCH iproute2 1/2] ip rule: merge ip rule flush and list, save together Hangbin Liu
2016-09-22  6:28 ` [PATCH iproute2 2/2] ip rule: add selector support Hangbin Liu
2016-09-22  8:45   ` Phil Sutter [this message]
2016-09-23  3:06     ` Hangbin Liu
2016-09-22 23:43 ` [PATCH iproute2 0/2] ip rule: merger iprule_flush and " Stephen Hemminger
2016-10-10  2:30 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922084553.GA22100@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).