From: Andrew Lunn <andrew@lunn.ch>
To: Jaedon Shin <jaedon.shin@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Philippe Reynes <tremyfr@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Fix EPHY reset in power up
Date: Fri, 23 Sep 2016 16:06:09 +0200 [thread overview]
Message-ID: <20160923140609.GA22965@lunn.ch> (raw)
In-Reply-To: <20160923132004.5734-1-jaedon.shin@gmail.com>
On Fri, Sep 23, 2016 at 10:20:04PM +0900, Jaedon Shin wrote:
> The bcmgenet_mii_reset() is always not running in power up sequence
> after 'commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from
> struct net_device")'. This'll show extremely high latency and duplicate
> packets while interface down and up repeatedly.
>
> For now, adds again a private phydev for mii reset when runs power up to
> open interface.
Hi Jaedon
How does this fix the issue? It sounds like you are papering over the
crack, not truly fixing it.
Andrew
next prev parent reply other threads:[~2016-09-23 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:20 [PATCH] net: bcmgenet: Fix EPHY reset in power up Jaedon Shin
2016-09-23 14:06 ` Andrew Lunn [this message]
2016-09-23 15:04 ` Jaedon Shin
2016-09-23 16:54 ` Florian Fainelli
2016-09-23 20:55 ` Jaedon Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923140609.GA22965@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).