From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq
Date: Sun, 25 Sep 2016 23:40:12 -0400 (EDT) [thread overview]
Message-ID: <20160925.234012.933201102491235169.davem@davemloft.net> (raw)
In-Reply-To: <20160925211445.11234-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Sun, 25 Sep 2016 14:14:45 -0700
> From: Colin Ian King <colin.king@canonical.com>
>
> iq is unsigned, so the error check for iq < 0 has no effect so errors
> can slip past this check. Fix this by making iq signed and also
> get_filter_steerq return a signed int so a -ve error can be returned.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
prev parent reply other threads:[~2016-09-26 3:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 21:14 [PATCH][V2] cxgb4: fix -ve error check on a signed iq Colin King
2016-09-26 3:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925.234012.933201102491235169.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=hariprasad@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).