* [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings
@ 2016-09-25 15:43 Wei Yongjun
2016-09-25 20:46 ` Vivien Didelot
2016-09-26 3:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-09-25 15:43 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warnings:
drivers/net/dsa/mv88e6xxx/chip.c:219:5: warning:
symbol 'mv88e6xxx_port_read' was not declared. Should it be static?
drivers/net/dsa/mv88e6xxx/chip.c:227:5: warning:
symbol 'mv88e6xxx_port_write' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 25bd3fa..6f28f19 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -216,16 +216,16 @@ int mv88e6xxx_write(struct mv88e6xxx_chip *chip, int addr, int reg, u16 val)
return 0;
}
-int mv88e6xxx_port_read(struct mv88e6xxx_chip *chip, int port, int reg,
- u16 *val)
+static int mv88e6xxx_port_read(struct mv88e6xxx_chip *chip, int port, int reg,
+ u16 *val)
{
int addr = chip->info->port_base_addr + port;
return mv88e6xxx_read(chip, addr, reg, val);
}
-int mv88e6xxx_port_write(struct mv88e6xxx_chip *chip, int port, int reg,
- u16 val)
+static int mv88e6xxx_port_write(struct mv88e6xxx_chip *chip, int port, int reg,
+ u16 val)
{
int addr = chip->info->port_base_addr + port;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings
2016-09-25 15:43 [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings Wei Yongjun
@ 2016-09-25 20:46 ` Vivien Didelot
2016-09-26 3:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2016-09-25 20:46 UTC (permalink / raw)
To: Wei Yongjun, Andrew Lunn, Florian Fainelli; +Cc: Wei Yongjun, netdev
Hi Wei,
Wei Yongjun <weiyj.lk@gmail.com> writes:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warnings:
>
> drivers/net/dsa/mv88e6xxx/chip.c:219:5: warning:
> symbol 'mv88e6xxx_port_read' was not declared. Should it be static?
> drivers/net/dsa/mv88e6xxx/chip.c:227:5: warning:
> symbol 'mv88e6xxx_port_write' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Thanks,
Vivien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings
2016-09-25 15:43 [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings Wei Yongjun
2016-09-25 20:46 ` Vivien Didelot
@ 2016-09-26 3:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-09-26 3:49 UTC (permalink / raw)
To: weiyj.lk; +Cc: andrew, vivien.didelot, f.fainelli, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Sun, 25 Sep 2016 15:43:02 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warnings:
>
> drivers/net/dsa/mv88e6xxx/chip.c:219:5: warning:
> symbol 'mv88e6xxx_port_read' was not declared. Should it be static?
> drivers/net/dsa/mv88e6xxx/chip.c:227:5: warning:
> symbol 'mv88e6xxx_port_write' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-26 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-25 15:43 [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warnings Wei Yongjun
2016-09-25 20:46 ` Vivien Didelot
2016-09-26 3:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).