From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver Date: Mon, 26 Sep 2016 15:07:24 -0600 Message-ID: <20160926210724.GA16413@obsidianresearch.com> References: <20160925070352.GU4088@leon.nu> <9f65ab5c-d8c2-e8e3-9334-5d1865a20dc9@vmware.com> <20160926165104.GA12011@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Leon Romanovsky , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org To: Adit Ranadive Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote: > Wouldnt they be some overlap between the user-space and kernel driver? Or is > it expected that the common structures (even device specific ones) be moved to > the ABI file? Yes, even device specific structures must be in the abi file. Anything that is used with copy_to_user/copy_from_user/etc. > For the mlx4 driver I see that the structures in include/linux/mlx4/qp.h > and in libmlx4/src/wqe.h are similar. We are trying to clean exactly that sort of stuff up, please try not to add more. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html