From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 0/3] ipsec: flow cache removal
Date: Tue, 27 Sep 2016 22:15:01 -0400 (EDT) [thread overview]
Message-ID: <20160927.221501.123624802268529925.davem@davemloft.net> (raw)
In-Reply-To: <1474992323-11327-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Tue, 27 Sep 2016 18:05:20 +0200
> Please do not apply these patches.
To be honest, I really want to :-)
> These are part of tests I made for the ipsec workshop at upcoming
> netdev 1.2 and I wanted to post these before the conference.
>
> Short version is that there appear to be no major scalability issues
> anymore without flow cache. Performance hit can be up to 30%
> in my tests (with 64 byte packets), however without flow cache we
> also avoid some undesirable effects when flow cache is constantly
> overloaded.
>
> Seems most of the extra cost is mainly because of extra xfrm dst
> init/destruction (and not e.g. due to policy lookup).
Yes, if you have to allocate/destroy a dst every lookup then
it will hurt a lot. Perhaps we can have a pre-cooked dst hung
off of some existing object as a first level strategy to avoid
this.
> Lets discuss more at the workshop.
Indeed.
prev parent reply other threads:[~2016-09-28 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:05 [RFC 0/3] ipsec: flow cache removal Florian Westphal
2016-09-27 16:05 ` [RFC 1/3] xfrm: state: do not acquire lock in get_mtu helpers Florian Westphal
2016-09-27 16:05 ` [RFC 2/3] vti: revert flush x-netns xfrm cache when vti interface is removed Florian Westphal
2016-09-27 16:05 ` [RFC 3/3] xfrm: remove flow cache Florian Westphal
2016-09-28 2:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927.221501.123624802268529925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).