From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
linville@tuxdriver.com, andy@greyhouse.net, f.fainelli@gmail.com,
dsa@cumulusnetworks.com, jhs@mojatatu.com,
vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
ivecera@redhat.com, kaber@trash.net, john@phrozen.org
Subject: Re: [patch net-next v3 0/6] fib offload: switch to notifier
Date: Wed, 28 Sep 2016 04:49:30 -0400 (EDT) [thread overview]
Message-ID: <20160928.044930.430080084052194610.davem@davemloft.net> (raw)
In-Reply-To: <1474887154-6286-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 26 Sep 2016 12:52:28 +0200
> The goal of this patchset is to allow driver to propagate all prefixes
> configured in kernel down HW. This is necessary for routing to work
> as expected. If we don't do that HW might forward prefixes known to kernel
> incorrectly. Take an example when default route is set in switch HW and there
> is an IP address set on a management (non-switch) port.
>
> Currently, only FIB entries related to the switch port netdev are
> offloaded using switchdev ops. This model is not extendable so the
> first patch introduces a replacement: notifier to propagate FIB entry
> additions and removals to whoever is interested.
Although I am disappointed that we need to use notifiers to support
fib offloading properly (it seems ad-hoc and hackish), I cannot come
up with a better solution to the problem. :-)
So series applied, thanks Jiri!
prev parent reply other threads:[~2016-09-28 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:52 [patch net-next v3 0/6] fib offload: switch to notifier Jiri Pirko
2016-09-26 10:52 ` [patch net-next v3 1/6] fib: introduce FIB notification infrastructure Jiri Pirko
2016-09-26 10:52 ` [patch net-next v3 2/6] fib: introduce FIB info offload flag helpers Jiri Pirko
2016-09-26 10:52 ` [patch net-next v3 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls Jiri Pirko
2016-09-26 11:11 ` Ido Schimmel
2016-09-26 10:52 ` [patch net-next v3 4/6] rocker: use " Jiri Pirko
2016-09-26 10:52 ` [patch net-next v3 5/6] switchdev: remove FIB offload infrastructure Jiri Pirko
2016-09-26 10:52 ` [patch net-next v3 6/6] doc: update switchdev L3 section Jiri Pirko
2016-09-28 8:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928.044930.430080084052194610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=dsa@cumulusnetworks.com \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john@phrozen.org \
--cc=kaber@trash.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).