From: David Miller <davem@davemloft.net>
To: brakmo@fb.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com,
eric.dumazet@gmail.com, ycheng@google.com, ncardwell@google.com
Subject: Re: [PATCH v4 net-next] tcp: Change txhash on every SYN and RTO retransmit
Date: Wed, 28 Sep 2016 07:52:59 -0400 (EDT) [thread overview]
Message-ID: <20160928.075259.495409427572927438.davem@davemloft.net> (raw)
In-Reply-To: <20160928020337.3057238-1-brakmo@fb.com>
From: Lawrence Brakmo <brakmo@fb.com>
Date: Tue, 27 Sep 2016 19:03:37 -0700
> The current code changes txhash (flowlables) on every retransmitted
> SYN/ACK, but only after the 2nd retransmitted SYN and only after
> tcp_retries1 RTO retransmits.
>
> With this patch:
> 1) txhash is changed with every SYN retransmits
> 2) txhash is changed with every RTO.
>
> The result is that we can start re-routing around failed (or very
> congested paths) as soon as possible. Otherwise application health
> checks may fail and the connection may be terminated before we start
> to change txhash.
>
> v4: Removed sysctl, txhash is changed for all RTOs
> v3: Removed text saying default value of sysctl is 0 (it is 100)
> v2: Added sysctl documentation and cleaned code
>
> Tested with packetdrill tests
>
> Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
Applied, thanks.
prev parent reply other threads:[~2016-09-28 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 2:03 [PATCH v4 net-next] tcp: Change txhash on every SYN and RTO retransmit Lawrence Brakmo
2016-09-28 11:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928.075259.495409427572927438.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brakmo@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=kernel-team@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox