From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: pravin shelar <pshelar@ovn.org>,
"David S . Miller" <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push()
Date: Wed, 28 Sep 2016 11:13:10 +0300 [thread overview]
Message-ID: <20160928111310.12ce6961@pixies> (raw)
In-Reply-To: <CAOrHB_C6H8AqqfLDvj296LnnLC7dLX5724cxGXujLTbgSBf50A@mail.gmail.com>
Hi,
On Tue, 27 Sep 2016 13:04:35 -0700, pshelar@ovn.org wrote:
>
> OVS MPLS does depends on mac-len to track MPLS header (ref
> skb_mpls_header()). Therefore vlan header changes needs to update
> mac-len.
Thanks for the explanation.
I'm working on a better fix.
Regards,
Shmulik
prev parent reply other threads:[~2016-09-28 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 17:31 [PATCH net] net: skbuff: Fix incorrect skb->mac_len adjustment in skb_vlan_push() Shmulik Ladkani
2016-09-27 20:04 ` pravin shelar
2016-09-28 8:13 ` Shmulik Ladkani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928111310.12ce6961@pixies \
--to=shmulik.ladkani@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).