From: David Miller <davem@davemloft.net>
To: dmitry.torokhov@gmail.com
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner
Date: Fri, 30 Sep 2016 01:21:27 -0400 (EDT) [thread overview]
Message-ID: <20160930.012127.347186046201932283.davem@davemloft.net> (raw)
In-Reply-To: <CAKdAkRRsVaAupFx+DpjX8VSHS9_ws2WVA47eQoCU-DT1w0JK5w@mail.gmail.com>
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Thu, 29 Sep 2016 08:46:05 -0700
> Hi David,
>
> On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> If net namespace is attached to a user namespace let's make container's
>> root owner of sysctls affecting said network namespace instead of global
>> root.
>>
>> This also allows us to clean up net_ctl_permissions() because we do not
>> need to fudge permissions anymore for the container's owner since it now
>> owns the objects in question.
>>
>> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> I was looking at linux-next today, and I noticed that, when you merged
> my patch, you basically reverted the following commit:
>
> commit d6e0d306449bcb5fa3c80e7a3edf11d45abf9ae9
> Author: Tyler Hicks <tyhicks@canonical.com>
> Date: Thu Jun 2 23:43:22 2016 -0500
>
> net: Use ns_capable_noaudit() when determining net sysctl permissions
Please send me a fixup patch for this, sorry.
next prev parent reply other threads:[~2016-09-30 5:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 21:35 [PATCH v2 0/3] Make /proc per net namespace objects belong to container Dmitry Torokhov
2016-08-10 21:36 ` [PATCH v2 1/3] netns: do not call pernet ops for not yet set up init_net namespace Dmitry Torokhov
2016-08-10 21:36 ` [PATCH v2 2/3] proc: make proc entries inherit ownership from parent Dmitry Torokhov
2016-08-10 21:36 ` [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner Dmitry Torokhov
2016-09-29 15:46 ` Dmitry Torokhov
2016-09-30 5:21 ` David Miller [this message]
2016-09-30 22:26 ` Dmitry Torokhov
2016-08-15 4:09 ` [PATCH v2 0/3] Make /proc per net namespace objects belong to container David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930.012127.347186046201932283.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).