From: David Miller <davem@davemloft.net>
To: gpiccoli@linux.vnet.ibm.com
Cc: ariel.elior@qlogic.com, Yuval.Mintz@qlogic.com, netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump
Date: Fri, 30 Sep 2016 01:22:50 -0400 (EDT) [thread overview]
Message-ID: <20160930.012250.1203085597428305997.davem@davemloft.net> (raw)
In-Reply-To: <57ED3F1B.2040602@linux.vnet.ibm.com>
From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Date: Thu, 29 Sep 2016 13:19:39 -0300
> David, thanks for your comment. I confess I didn't understand your
> statement quite well. You say we shouldn't dump registers that will
> cause timeouts, that's it?
Yes, basically.
If this happened infrequently for one or two registers maybe
that would be OK, but this seems to timeout on many registers
especially if the device is up and operational during the
"ethtool -d", and that's a bit much.
prev parent reply other threads:[~2016-09-30 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:33 [PATCH RFC net-next] bnx2x: avoid printing unnecessary messages during register dump Guilherme G. Piccoli
2016-09-28 2:43 ` David Miller
2016-09-29 16:19 ` Guilherme G. Piccoli
2016-09-30 5:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930.012250.1203085597428305997.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@qlogic.com \
--cc=ariel.elior@qlogic.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).