From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division Date: Fri, 30 Sep 2016 19:46:50 +0200 Message-ID: <20160930174650.GE1176@salvia> References: <20160929173950.GA27689@akamai.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: johunt@akamai.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, pai.vishwain@gmail.com, kaber@trash.net, kadlec@blackhole.kfki.hu, zlpnobody@gmail.com, hannes@stressinduktion.org, maze@google.com, eric.dumazet@gmail.com, akpm@linux-foundation.org To: Vishwanath Pai Return-path: Received: from mail.us.es ([193.147.175.20]:60626 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932887AbcI3RrA (ORCPT ); Fri, 30 Sep 2016 13:47:00 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 5307AE3A1B for ; Fri, 30 Sep 2016 19:46:57 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3F426DA850 for ; Fri, 30 Sep 2016 19:46:57 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 123AFDA853 for ; Fri, 30 Sep 2016 19:46:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160929173950.GA27689@akamai.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 29, 2016 at 01:39:50PM -0400, Vishwanath Pai wrote: > v2: > Remove unnecessary div64_u64 around constants > > v3: > remove backslashes > > -- > > Fix link error in 32bit arch because of 64bit division > > Division of 64bit integers will cause linker error undefined reference > to `__udivdi3'. Fix this by replacing divisions with div64_64 Applied, thanks Pai. > Signed-off-by: Vishwanath Pai > Fixes: 11d5f15723c9 ("netfilter: xt_hashlimit: Create revision 2 to ...") > > --- Please, next time place the versioning information here, otherwise git am takes the wrong description here.