From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: maze@google.com, netdev@vger.kernel.org, ek@google.com,
lorenzo@google.com
Subject: Re: [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop_limit()
Date: Sun, 02 Oct 2016 23:48:31 -0400 (EDT) [thread overview]
Message-ID: <20161002.234831.149876659535482615.davem@davemloft.net> (raw)
In-Reply-To: <1475134423-23635-1-git-send-email-zenczykowski@gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Thu, 29 Sep 2016 00:33:43 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> This is an effective no-op in terms of user observable behaviour.
>
> By preventing the overwrite of non-null extra1/extra2 fields
> in addrconf_sysctl() we can enable the use of proc_dointvec_minmax().
>
> This allows us to eliminate the constant min/max (1..255) trampoline
> function that is addrconf_sysctl_hop_limit().
>
> This is nice because it simplifies the code, and allows future
> sysctls with constant min/max limits to also not require trampolines.
>
> We still can't eliminate the trampoline for mtu because it isn't
> actually a constant (it depends on other tunables of the device)
> and thus requires at-write-time logic to enforce range.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Applied, thanks.
prev parent reply other threads:[~2016-10-03 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 7:33 [PATCH] ipv6 addrconf: remove addrconf_sysctl_hop_limit() Maciej Żenczykowski
2016-09-29 9:15 ` Erik Kline
2016-10-03 3:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002.234831.149876659535482615.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ek@google.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).