From: David Miller <davem@davemloft.net>
To: g.schenk@eckelmann.de
Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] net: fec: set mac address unconditionally
Date: Mon, 03 Oct 2016 01:28:03 -0400 (EDT) [thread overview]
Message-ID: <20161003.012803.1597598115167533192.davem@davemloft.net> (raw)
In-Reply-To: <1475228770-17504-1-git-send-email-g.schenk@eckelmann.de>
From: Gavin Schenk <g.schenk@eckelmann.de>
Date: Fri, 30 Sep 2016 11:46:10 +0200
> If the mac address origin is not dt, you can only safely assign a mac
> address after "link up" of the device. If the link is off the clocks are
> disabled and because of issues assigning registers when clocks are off the
> new mac address cannot be written in .ndo_set_mac_address() on some soc's.
> This fix sets the mac address unconditionally in fec_restart(...) and
> ensures consistency between fec registers and the network layer.
>
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> Acked-by: Fugang Duan <fugang.duan@nxp.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address")
> ---
> Changes since (implicit) v1:
> - reword commit log as suggested by Uwe
> - added Acks
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-10-03 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 9:46 [PATCH v2] net: fec: set mac address unconditionally Gavin Schenk
2016-10-03 5:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003.012803.1597598115167533192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=g.schenk@eckelmann.de \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox