From: David Miller <davem@davemloft.net>
To: bpoirier@suse.com
Cc: netdev@vger.kernel.org, skhare@vmware.com, pv-drivers@vmware.com
Subject: Re: [PATCH] vmxnet3: Wake queue from reset work
Date: Tue, 04 Oct 2016 00:36:40 -0400 (EDT) [thread overview]
Message-ID: <20161004.003640.2123697293503989553.davem@davemloft.net> (raw)
In-Reply-To: <20161003024750.30015-1-bpoirier@suse.com>
From: Benjamin Poirier <bpoirier@suse.com>
Date: Mon, 3 Oct 2016 10:47:50 +0800
> vmxnet3_reset_work() expects tx queues to be stopped (via
> vmxnet3_quiesce_dev -> netif_tx_disable). However, this races with the
> netif_wake_queue() call in netif_tx_timeout() such that the driver's
> start_xmit routine may be called unexpectedly, triggering one of the BUG_ON
> in vmxnet3_map_pkt with a stack trace like this:
...
> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Applied, thanks.
prev parent reply other threads:[~2016-10-04 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 2:47 [PATCH] vmxnet3: Wake queue from reset work Benjamin Poirier
2016-10-04 4:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004.003640.2123697293503989553.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bpoirier@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox