From: David Miller <davem@davemloft.net>
To: gwshan@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, joel@jms.id.au, yuvali@mellanox.com,
benh@kernel.crashing.org
Subject: Re: [PATCH v2 net-next 0/8] net/ncsi: NCSI Improvment and bug fixes
Date: Tue, 04 Oct 2016 02:13:25 -0400 (EDT) [thread overview]
Message-ID: <20161004.021325.1301099883976987002.davem@davemloft.net> (raw)
In-Reply-To: <1475540754-31169-1-git-send-email-gwshan@linux.vnet.ibm.com>
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
Date: Tue, 4 Oct 2016 11:25:46 +1100
> This series of patches improves NCSI stack according to the comments
> I received after the NCSI code was merged to 4.8.rc1:
>
> * PATCH[1/8] fixes the build warning caused by xchg() with ia64-linux-gcc.
> The atomic operations are removed. The NCSI's lock should be taken when
> reading or updating its state and chained state.
> * Channel ID (0x1f) is the reserved one and it cannot be valid channel ID.
> So we needn't try to probe channel whose ID is 0x1f. PATCH[2/8] and
> PATCH[3/8] are addressing this issue.
> * The request IDs are assigned in round-robin fashion, but it's broken.
> PATCH[4/8] make it work.
> * PATCH[5/8] and PATCH[6/8] reworks the channel monitoring to improve the
> code readability and its robustness.
> * PATCH[7/8] and PATCH[8/8] introduces ncsi_stop_dev() so that the network
> device can be closed and opened afterwards. No error will be seen.
>
> Changelog
> =========
> v2:
> * The NCSI's lock is taken when reading or updating its state as the
> {READ,WRITE}_ONCE() isn't reliable.
Series applied, thanks.
prev parent reply other threads:[~2016-10-04 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 0:25 [PATCH v2 net-next 0/8] net/ncsi: NCSI Improvment and bug fixes Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 1/8] net/ncsi: Avoid unused-value build warning from ia64-linux-gcc Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 2/8] net/ncsi: Introduce NCSI_RESERVED_CHANNEL Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 3/8] net/ncsi: Don't probe on the reserved channel ID (0x1f) Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 4/8] net/ncsi: Rework request index allocation Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 5/8] net/ncsi: Allow to extend NCSI request properties Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 6/8] net/ncsi: Rework the channel monitoring Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 7/8] net/ncsi: Introduce ncsi_stop_dev() Gavin Shan
2016-10-04 0:25 ` [PATCH v2 net-next 8/8] net/faraday: Stop NCSI device on shutdown Gavin Shan
2016-10-04 6:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004.021325.1301099883976987002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=netdev@vger.kernel.org \
--cc=yuvali@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).