* [PATCH] net: hns: qdd missing \n to end of dev_err messages
@ 2016-10-04 11:06 Colin King
2016-10-04 12:31 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-10-04 11:06 UTC (permalink / raw)
To: Salil Mehta, David S . Miller, Kejian Yan, Daode Huang, lipeng,
Lisheng, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_err messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index a834774..7aeed08 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -547,7 +547,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable)
struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb);
if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) {
- dev_err(mac_cb->dev, "enable autoneg is not allowed!");
+ dev_err(mac_cb->dev, "enable autoneg is not allowed!\n");
return -ENOTSUPP;
}
@@ -571,7 +571,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en)
if (mac_cb->mac_type == HNAE_PORT_DEBUG) {
if (is_ver1 && (tx_en || rx_en)) {
- dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!");
+ dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!\n");
return -EINVAL;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages
2016-10-04 11:06 [PATCH] net: hns: qdd missing \n to end of dev_err messages Colin King
@ 2016-10-04 12:31 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2016-10-04 12:31 UTC (permalink / raw)
To: Colin King, Salil Mehta, David S . Miller, Kejian Yan,
Daode Huang, lipeng, Lisheng, netdev
Cc: linux-kernel
Hello.
On 10/04/2016 02:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> index a834774..7aeed08 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> @@ -547,7 +547,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable)
> struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb);
>
> if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) {
> - dev_err(mac_cb->dev, "enable autoneg is not allowed!");
> + dev_err(mac_cb->dev, "enable autoneg is not allowed!\n");
Enabling, perhaps?
> return -ENOTSUPP;
> }
>
> @@ -571,7 +571,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en)
>
> if (mac_cb->mac_type == HNAE_PORT_DEBUG) {
> if (is_ver1 && (tx_en || rx_en)) {
> - dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!");
> + dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!\n");
Perhaps a good time to fix this "cann't"?
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-04 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 11:06 [PATCH] net: hns: qdd missing \n to end of dev_err messages Colin King
2016-10-04 12:31 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox