From: David Miller <davem@davemloft.net>
To: anoob.soman@citrix.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] packet: call fanout_release, while UNREGISTERING a netdev
Date: Thu, 06 Oct 2016 20:50:52 -0400 (EDT) [thread overview]
Message-ID: <20161006.205052.1380596858044266995.davem@davemloft.net> (raw)
In-Reply-To: <1475676774-18726-1-git-send-email-anoob.soman@citrix.com>
From: Anoob Soman <anoob.soman@citrix.com>
Date: Wed, 5 Oct 2016 15:12:54 +0100
> If a socket has FANOUT sockopt set, a new proto_hook is registered
> as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
> af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
> registered as part of fanout_add is not removed. Call fanout_release, on a
> NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
> fanout_list.
>
> This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()
>
> Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2016-10-07 0:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 14:12 [PATCH net] packet: call fanout_release, while UNREGISTERING a netdev Anoob Soman
2016-10-07 0:50 ` David Miller [this message]
2017-01-30 17:26 ` Eric Dumazet
2017-01-30 18:19 ` Anoob Soman
2017-01-30 19:08 ` Anoob Soman
2017-01-30 19:44 ` Eric Dumazet
2017-01-31 17:03 ` Anoob Soman
2017-01-31 18:00 ` Eric Dumazet
2017-01-31 18:14 ` Anoob Soman
2017-02-02 14:42 ` Anoob Soman
2017-02-02 15:53 ` Eric Dumazet
2017-02-02 16:44 ` Anoob Soman
2017-02-02 17:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006.205052.1380596858044266995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anoob.soman@citrix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).