From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: timur@codeaurora.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM
Date: Thu, 06 Oct 2016 21:13:51 -0400 (EDT) [thread overview]
Message-ID: <20161006.211351.701656198910382646.davem@davemloft.net> (raw)
In-Reply-To: <1475765093-15536-1-git-send-email-geert@linux-m68k.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 6 Oct 2016 16:44:53 +0200
> If NO_DMA=y:
>
> drivers/built-in.o: In function `emac_probe':
> emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
> emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
> drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
>
> If NO_IOMEM=y:
>
> drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
> drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(adpt->phy.digital);
> ^
>
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
prev parent reply other threads:[~2016-10-07 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:44 [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS_IOMEM Geert Uytterhoeven
2016-10-06 14:48 ` Timur Tabi
2016-10-07 1:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006.211351.701656198910382646.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).