From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/6] qed: Allow chance for fast ramrod completions
Date: Mon, 10 Oct 2016 03:17:24 -0400 (EDT) [thread overview]
Message-ID: <20161010.031724.182767468453485783.davem@davemloft.net> (raw)
In-Reply-To: <BL2PR07MB230613EB6D587458F4143C678DDB0@BL2PR07MB2306.namprd07.prod.outlook.com>
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Mon, 10 Oct 2016 06:33:05 +0000
>
>> > + while (iter_cnt--) {
>> > + /* Validate we receive completion update */
>> > smp_rmb();
>> > if (comp_done->done == 1) {
>> > if (p_fw_ret)
>> > *p_fw_ret = comp_done->fw_return_code;
>> > return 0;
>> > }
>
>> Note that this smp_rmb() and accesses to ->done and ->fw_return_code are
>> racy.
>
>> fw_return_code needs to be written _before_ done.
>
> Thanks for catching this up.
>
> Dave - do you want me to re-spin for this?
Yes.
next prev parent reply other threads:[~2016-10-10 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 15:25 [PATCH net-next 0/6] qed*: driver updates Yuval Mintz
2016-10-09 15:25 ` [PATCH net-next 1/6] qed: Pass MAC hints to VFs Yuval Mintz
2016-10-09 15:25 ` [PATCH net-next 2/6] qede: GSO support for tunnels with outer csum Yuval Mintz
2016-10-09 15:25 ` [PATCH net-next 3/6] qede: Prevent GSO on long Geneve headers Yuval Mintz
2016-10-09 15:25 ` [PATCH net-next 4/6] qed*: Allow unicast filtering Yuval Mintz
2016-10-09 15:25 ` [PATCH net-next 5/6] qed: Allow chance for fast ramrod completions Yuval Mintz
2016-10-10 0:08 ` Eric Dumazet
2016-10-10 6:33 ` Mintz, Yuval
2016-10-10 7:17 ` David Miller [this message]
2016-10-09 15:25 ` [PATCH net-next 6/6] qed: Handle malicious VFs events Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010.031724.182767468453485783.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@cavium.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).