* [PATCH] drivers/ptp: Fix kernel memory disclosure
@ 2016-10-11 13:02 Vlad Tsyrklevich
2016-10-12 9:06 ` Richard Cochran
2016-10-13 14:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vlad Tsyrklevich @ 2016-10-11 13:02 UTC (permalink / raw)
To: netdev; +Cc: richardcochran, Vlad Tsyrklevich
The reserved field precise_offset->rsv is not cleared before being
copied to user space, leaking kernel stack memory. Clear the struct
before it's copied.
Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
---
drivers/ptp/ptp_chardev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index d637c93..58a97d4 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -193,6 +193,7 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
if (err)
break;
+ memset(&precise_offset, 0, sizeof(precise_offset));
ts = ktime_to_timespec64(xtstamp.device);
precise_offset.device.sec = ts.tv_sec;
precise_offset.device.nsec = ts.tv_nsec;
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/ptp: Fix kernel memory disclosure
2016-10-11 13:02 [PATCH] drivers/ptp: Fix kernel memory disclosure Vlad Tsyrklevich
@ 2016-10-12 9:06 ` Richard Cochran
2016-10-13 14:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2016-10-12 9:06 UTC (permalink / raw)
To: Vlad Tsyrklevich; +Cc: netdev
On Tue, Oct 11, 2016 at 03:02:47PM +0200, Vlad Tsyrklevich wrote:
> The reserved field precise_offset->rsv is not cleared before being
> copied to user space, leaking kernel stack memory. Clear the struct
> before it's copied.
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/ptp: Fix kernel memory disclosure
2016-10-11 13:02 [PATCH] drivers/ptp: Fix kernel memory disclosure Vlad Tsyrklevich
2016-10-12 9:06 ` Richard Cochran
@ 2016-10-13 14:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-13 14:20 UTC (permalink / raw)
To: vlad; +Cc: netdev, richardcochran
From: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Date: Tue, 11 Oct 2016 15:02:47 +0200
> The reserved field precise_offset->rsv is not cleared before being
> copied to user space, leaking kernel stack memory. Clear the struct
> before it's copied.
>
> Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Applied and queued up for -stable, thanks Vlad.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 14:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 13:02 [PATCH] drivers/ptp: Fix kernel memory disclosure Vlad Tsyrklevich
2016-10-12 9:06 ` Richard Cochran
2016-10-13 14:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).