From: David Miller <davem@davemloft.net>
To: khoroshilov@ispras.ru
Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()
Date: Thu, 13 Oct 2016 09:43:23 -0400 (EDT) [thread overview]
Message-ID: <20161013.094323.1769619439752576215.davem@davemloft.net> (raw)
In-Reply-To: <1475895223-3225-1-git-send-email-khoroshilov@ispras.ru>
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 7 Oct 2016 22:53:43 -0400
> vmxnet3_set_mc() still assumes zero is invalid pa:
> it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails;
> it calls dma_unmap_single() iff new_table_pa is not zero.
>
> The patch adds an explicit variable to track status of new_table_pa.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Please use "bool" and "true"/"false" for boolean variables.
Thanks.
next prev parent reply other threads:[~2016-10-13 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 2:53 [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() Alexey Khoroshilov
2016-10-13 13:43 ` David Miller [this message]
2016-10-14 21:01 ` [PATCH v2] " Alexey Khoroshilov
2016-10-15 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013.094323.1769619439752576215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).