From: David Miller <davem@davemloft.net>
To: izumi.taku@jp.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver
Date: Thu, 13 Oct 2016 10:19:30 -0400 (EDT) [thread overview]
Message-ID: <20161013.101930.1034896203915503108.davem@davemloft.net> (raw)
In-Reply-To: <1476176120-18859-1-git-send-email-izumi.taku@jp.fujitsu.com>
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
Date: Tue, 11 Oct 2016 17:55:20 +0900
> This patch implements debug mode for fjes driver.
> You can get firmware activity information by enabling
> debug mode. This is useful for debugging.
>
> To enable debug mode, write value of debugging mode to
> debug_mode file in debugfs:
>
> # echo 1 > /sys/kernel/debug/fjes/fjes.0/debug_mode
>
> To disable debug mode, write 0 to debug_mode file in debugfs:
>
> # echo 0 > /sys/kernel/debug/fjes/fjes.0/debug_mode
>
> Firmware activity information can be retrieved via
> /sys/kernel/debug/fjes/fjes.0/debug_data file.
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
There is no reason to use debugfs for this, we have facilities such
as ETHTOOL_SET_DUMP et al. that you can use to implement this.
next prev parent reply other threads:[~2016-10-13 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 8:54 [PATCH net-next 0/6] FUJITSU Extended Socket driver version 1.2 Taku Izumi
2016-10-11 8:54 ` [PATCH 1/6] fjes: ethtool -d support for fjes driver Taku Izumi
2016-10-11 8:55 ` [PATCH 2/6] fjes: Enhance ethtool -S " Taku Izumi
2016-10-11 8:55 ` [PATCH 3/6] fjes: Add tracepoints in " Taku Izumi
2016-10-11 8:55 ` [PATCH 4/6] fjes: Implement debug mode for " Taku Izumi
2016-10-13 14:19 ` David Miller [this message]
2016-10-14 7:30 ` Izumi, Taku
2016-10-11 8:55 ` [PATCH 5/6] fjes: Add debugfs entry for EP status information in " Taku Izumi
2016-10-11 8:55 ` [PATCH 6/6] fjes: Update fjes driver version : 1.2 Taku Izumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013.101930.1034896203915503108.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=izumi.taku@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox