From: David Miller <davem@davemloft.net>
To: dledford@redhat.com
Cc: pabeni@redhat.com, linux-rdma@vger.kernel.org,
sean.hefty@intel.com, hal.rosenstock@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header
Date: Thu, 13 Oct 2016 11:57:08 -0400 (EDT) [thread overview]
Message-ID: <20161013.115708.2077879944453283228.davem@davemloft.net> (raw)
In-Reply-To: <2eadc083-e2e0-5c6d-fe84-c5851be3e2ec@redhat.com>
From: Doug Ledford <dledford@redhat.com>
Date: Thu, 13 Oct 2016 11:20:59 -0400
> We *had* a safe way to do that. It got broken. What about increasing
> the size of skb->cb? Or adding a skb->dgid that is a
> u8[INFINIBAND_ALEN]? Or a more generic skb->dest_ll_addr that is sized
> to hold the dest address for any link layer?
I understand the situation, and I also believe that making sk_buff any
huger than it already is happens to be a non-starter.
>> Pushing metadata before the head of the SKB data pointer is illegal,
>> as the layers in between might want to push protocol headers,
>
> That's a total non-issue for us. There are no headers that protocols
> can add before ours.
Ok, if that's the case, and based upon Paolo's response to me it appears
to be, I guess this is OK for now.
Paolo please resubmit your patch, thanks.
next prev parent reply other threads:[~2016-10-13 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:15 [PATCH] IB/ipoib: move back the IB LL address into the hard header Paolo Abeni
[not found] ` <1dbd83dfe7f435eecc5bc460e901b47758280f30.1476206016.git.pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-11 17:32 ` Jason Gunthorpe
2016-10-11 17:37 ` Paolo Abeni
[not found] ` <1476207452.448.2.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-11 17:42 ` Jason Gunthorpe
[not found] ` <20161011174224.GA17319-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 17:52 ` Paolo Abeni
2016-10-11 17:41 ` Doug Ledford
2016-10-11 18:01 ` Jason Gunthorpe
2016-10-11 18:10 ` Paolo Abeni
[not found] ` <1476209407.448.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-11 18:17 ` Doug Ledford
[not found] ` <073e0007-a43b-134d-ba7e-b290304be585-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-11 18:30 ` Jason Gunthorpe
[not found] ` <20161011183019.GC20253-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 18:50 ` Doug Ledford
2016-10-12 18:21 ` Doug Ledford
2016-10-11 18:27 ` Jason Gunthorpe
2016-10-13 14:24 ` David Miller
[not found] ` <20161013.102432.1450901395774429343.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-10-13 14:35 ` Doug Ledford
2016-10-13 14:43 ` [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: " David Miller
[not found] ` <20161013.104314.1842951254979604965.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-10-13 15:20 ` Doug Ledford
2016-10-13 15:57 ` David Miller [this message]
2016-10-13 15:17 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013.115708.2077879944453283228.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).