Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels
Date: Thu, 13 Oct 2016 15:17:00 -0400 (EDT)	[thread overview]
Message-ID: <20161013.151700.1071876162706356206.davem@davemloft.net> (raw)
In-Reply-To: <20161012232547.2383961-1-tom@herbertland.com>

From: Tom Herbert <tom@herbertland.com>
Date: Wed, 12 Oct 2016 16:25:42 -0700

> Since performing a UDP lookup on every packet might be expensive I
> added a static key check to bypass the lookup if there are no
> sockets with flow_dissect set. I should mention that doing the
> lookup wasn't particularly a big hit anyway.

I think this new static key is unnecessary, as it is equivalent
to: (udp_encap_needed + udpv6_encap_needed)

This socket lookup is very heavy handed, and I realize that you
need this because we no longer store the encapsulation socket in
skb->sk these days.

Can you talk about the various code paths that lead into the
flow dissector and why the UDP socket lookup is needed?  Maybe
we can propagate it another way, at least on TX.

Thanks.

  parent reply	other threads:[~2016-10-13 19:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 23:25 [PATCH net-next 0/5] udp: Flow dissection for tunnels Tom Herbert
2016-10-12 23:25 ` [PATCH net-next 1/5] udp: Add socket lookup functions with noref Tom Herbert
2016-10-12 23:25 ` [PATCH net-next 2/5] udp: UDP flow dissector Tom Herbert
2016-10-12 23:25 ` [PATCH net-next 3/5] udp: Add UDP flow dissection functions to IPv4 and IPv6 Tom Herbert
2016-10-12 23:25 ` [PATCH net-next 4/5] udp: UDP tunnel flow dissection infrastructure Tom Herbert
2016-10-12 23:25 ` [PATCH net-next 5/5] fou: Support flow dissection Tom Herbert
2016-10-13 19:17 ` David Miller [this message]
2016-10-13 19:29   ` [PATCH net-next 0/5] udp: Flow dissection for tunnels Tom Herbert
2016-10-14 15:03     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013.151700.1071876162706356206.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox